Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the dQ/dx information from the track #311

Merged
merged 4 commits into from
Jul 16, 2024

Conversation

tmadlener
Copy link
Contributor

@tmadlener tmadlener commented May 28, 2024

BEGINRELEASENOTES

  • Remove the dQ/dx information from the Track
  • Add TrackPIDHandler to allow for the reverse lookup

ENDRELEASENOTES

@tmadlener
Copy link
Contributor Author

Make a dedicated type for the dE/dx (or dN/dx) information and don't reuse the RecDqdx.

@tmadlener
Copy link
Contributor Author

The FCCAnalyses part will most likely be rather involved, as some of the logic that is used there will simply no longer work as easily.

@tmadlener tmadlener force-pushed the rm-dqdx-from-track branch from 5b7b0c0 to 14ca9e3 Compare July 10, 2024 08:15
@tmadlener
Copy link
Contributor Author

As discussed in todays meeting: prioritize an EDM4hep pre-release and for the moment turn-off the dE/dx features in FCCAnalyses and bring them back to live after the pre-release.

@tmadlener tmadlener changed the title [WIP] Remove the dQ/dx information from the track Remove the dQ/dx information from the track Jul 16, 2024
@tmadlener
Copy link
Contributor Author

With all the PRs mentioned in the top level comment, I am able to build the complete stack locally. I will merge all of them in the afternoon, to get them into the nightlies for tomorrow.

@tmadlener tmadlener merged commit ae9b794 into key4hep:main Jul 16, 2024
8 of 11 checks passed
@tmadlener tmadlener deleted the rm-dqdx-from-track branch July 16, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant